Remove unstable module check, add --skip-wasm-validation
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
changed the title
__unstable__ module check, add --skip-wasm-validationunstable module check, add --skip-wasm-validation
deuszx
added a commit
to Cardinal-Cryptography/ink4-migration
that referenced
this pull request
Jan 7, 2023
It's not available on production chains, even though it does exist in the code. For more details, see: - paritytech/substrate#12781 - use-ink/ink#1522 - use-ink/cargo-contract#846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to use-ink/ink#1522.
Imports from
__unstable__modules now invalid. However I have added an escape hatch--skip-wasm-validationwhich skips this check in case the user wants to build an incompatible version ofink!.