Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add section Upgradeable Contracts #85

Merged
merged 6 commits into from
Sep 14, 2022
Merged

add section Upgradeable Contracts #85

merged 6 commits into from
Sep 14, 2022

Conversation

SkymanOne
Copy link
Contributor

closes #82

@SkymanOne
Copy link
Contributor Author

While we are waiting on the progress on #1338 from ink repo. The section can just contain forward_call and set_code_cash

@SkymanOne SkymanOne marked this pull request as ready for review September 7, 2022 15:11
HCastano
HCastano reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be a good addition to the docs, thanks!

Can you wrap lines to 90ish characters? Makes it easier to
read the source files

docs/basics/upgradeability.md Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
cmichi
cmichi reviewed Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Got some nits.

docs/basics/upgradeability.md Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
docs/basics/upgradeability.md Outdated Show resolved Hide resolved
@SkymanOne @HCastano @cmichi
Apply suggestions from code review
c19289a 
Co-authored-by: Hernando Castano <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
@cmichi cmichi merged commit 8144d73 into master Sep 14, 2022
@cmichi cmichi deleted the gn-contracts-upgrade branch September 14, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@ascjones ascjones Awaiting requested review from ascjones ascjones is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add section "Upgradeable Contracts"
3 participants
@SkymanOne @cmichi @HCastano