Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different implementation of delegator example and dao contract #14

Closed
wants to merge 3 commits into from

Conversation

Daanvdplas
Copy link

@Daanvdplas Daanvdplas commented Apr 3, 2023

I wrote a different implementation of the delegator example where in stead of instantiating all the contracts when instantiating the delegator contract, the delegator contract is instantiated with already instantiated contracts.

It shows a more extended example of using the build_call in a contract message, as well as how to e2e-test it.

I'm curious to hear whether it could be useful. If I need to make some changes or thoughts for improvement I'd love to hear (e.g. perhaps a better name)!

@Daanvdplas Daanvdplas changed the title Add different version for delegator example Add different implementation of delegator example Apr 3, 2023
@Daanvdplas Daanvdplas changed the title Add different implementation of delegator example Add different implementation of delegator example and dao contract Apr 14, 2023
@Daanvdplas
Copy link
Author

Daanvdplas commented Apr 14, 2023

Added a DAO smart contract.

Commented out emit_event() logic which is not possible at the moment, due to cross contract implementation (issue), but is good to include in the future.

Would love to get feedback :)

@cmichi
Copy link
Collaborator

cmichi commented Apr 16, 2023

Heya @Daanvdplas, thanks for the example! Could you close this PR and recreate it for the ink repo into the integration-tests folder there?

@Daanvdplas Daanvdplas closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants