Bump secp256k1 to v0.24.2
#1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions `>= 0.24.0` have a soundness bug, so we need to ensure people are using `>= 0.24.2` See here for more: rustsec/advisory-db#1480
ascjones
approved these changes
Dec 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #1528 +/- ##
==========================================
- Coverage 71.67% 71.61% -0.07%
==========================================
Files 204 204
Lines 6320 6320
==========================================
- Hits 4530 4526 -4
- Misses 1790 1794 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Out of curiosity, how did you find out so fast? RustSec wasn't even touched by the maintainers not to mention merging. |
|
@Kixunil haha, mostly a coincidence. I was checking the installation of a new Started digging as to why and landed on that PR |
|
Oh, wow, that wasn't that much of a coincidence then since we purposely yanked it to cause this warning. Happy it worked! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
>= 0.24.0have a soundness bug, so we need to ensure peopleare using
>= 0.24.2See here for more: rustsec/advisory-db#1480