-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up: Implement storage2 trait derive proc. macros #399
Conversation
Also simplified its dependencies a bit.
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 86.34% 86.27% -0.08%
==========================================
Files 131 134 +3
Lines 5727 5821 +94
==========================================
+ Hits 4945 5022 +77
- Misses 782 799 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// we use the array indexing trick to compute the maximum element: | ||
/// | ||
/// ```no_compile | ||
/// max(a, b) = [a, b][(a < b) as usize] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
Follow up for #311 .
Adds derive proc. macros for the
SpreadLayout
andPackedLayout
traits of the newink_core::storage2
module.Must not be merged before #311 is merged.
This PR also improves the structure of the
ink_core/derive
crate.Moves
AllocateUsing
andFlush
derives into their own files.Move to
synstructure
tests for the new trait derive proc. macros instead of the current test framework.