[metadata] update to scale-info 0.3, removes string interning #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lang/macro/src/codegen/metadata.rs
Allows converting an instance into code that can construct that instance. For use from `cargo-contract`.
Robbepop
reviewed
Jul 7, 2020
ascjones
changed the title
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
- Coverage 86.83% 84.97% -1.86%
==========================================
Files 135 125 -10
Lines 5877 5392 -485
==========================================
- Hits 5103 4582 -521
- Misses 774 810 +36
Continue to review full report at Codecov.
|
ascjones
changed the title
ascjones
commented
Jul 15, 2020
| @@ -255,7 +255,7 @@ publish-docs: | |||
| - git fetch origin gh-pages | |||
| # Generating Docs | |||
| - time cargo doc --no-deps --all-features | |||
| -p scale-info -p ink_metadata -p ink_metadata_derive -p ink_core -p ink_core_derive | |||
| -p scale-info -p ink_metadata -p ink_core -p ink_core_derive | |||
There was a problem hiding this comment.
This should fix the master branch CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #299.
scale-info0.3 which removes the string interning, making all strings inline.Adds struct name to the layout.Removed because this is anink!specific concept and not currently required by 3rd party toolsNote: Previously this PR contained additional metadata data structures, which have now been moved over to
cargo-contract. See use-ink/cargo-contract#62