Fix Codecov measuring and Publishing #863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriplEight
changed the title
Causes a linker error when building `08-flipper-as-dependency-trait` due to `__ink_enforce_error` otherwise.
|
Regarding the linker failure: |
|
dropping |
|
sadly |
…k into 3x8_fix_codecov_publishing
TriplEight
changed the title
Robbepop
reviewed
Jul 20, 2021
|
OK, now it works properly. |
HCastano
reviewed
Jul 20, 2021
|
Now, I'm not an expert in all those flags and in fact I wanted you guys to take a look at the quality of the coverage and come up with the decision whether it's good enough (better than previous). |
|
Did some research See https://github.com/taiki-e/cargo-llvm-cov#continuous-integration and notes below
Also rust-lang/rust#86177
And a tracking issue about source-based coverage rust-lang/rust#79121 All of it means that the current state of the PR means that we are thrown back to line coverage. |
|
Working MIR-based coverage lies in the commit above. However, it does not provide branches coverage and a lot of effort was put into it in ink!, so it was decided to return to the previous instrumentation. |
Merged
|
@TriplEight Can we close this PR, since we've merged #895 now? |
|
yes, but I'll note it for myself as a working example of the source-based coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, after their security issue, Codecov decided to fix up some security. Now they require tokens even for public projects.
As for failing after the script, it used to before, but it's on their side, so now it does 👎 . This is fixed with
-Zoption.UPD: in fact, they've released a safer option to upload the test cov results, a binary. paritytech/scripts#318
UPD2: which does not actually work so far.
CC: #857
Closes: https://github.com/paritytech/ci_cd/issues/160