Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked message dispatch logic. Moved common parts upper. #999

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Nov 1, 2021

It is PR for the change #998. With this change Erc20 has size:
Original wasm size: 64.4K, Optimized: 28.3K

@Robbepop
Copy link
Collaborator

Robbepop commented Nov 3, 2021

Unfortunately I cannot review this atm, however, I'd really like to review this PR before it is being merged. I will do that asap.

@cmichi cmichi deleted the branch use-ink:master November 8, 2021 13:23
@cmichi cmichi closed this Nov 8, 2021
@cmichi
Copy link
Collaborator

cmichi commented Nov 8, 2021

@xgreenx I just merged #998, which automatically deleted that branch. In consequence this PR was closed by GitHub. I now restored the branch from #998, but you can change the base branch of this PR to ink! master now.

@cmichi cmichi reopened this Nov 8, 2021
@xgreenx xgreenx changed the base branch from rf-fix-result-returns to master November 8, 2021 13:25
@codecov-commenter
Copy link

Codecov Report

Merging #999 (6676c7c) into master (1393502) will decrease coverage by 0.35%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   78.78%   78.43%   -0.36%     
==========================================
  Files         244      245       +1     
  Lines        9188     9232      +44     
==========================================
+ Hits         7239     7241       +2     
- Misses       1949     1991      +42     
Impacted Files Coverage Δ
crates/env/src/api.rs 36.36% <0.00%> (ø)
crates/env/src/backend.rs 0.00% <ø> (ø)
crates/env/src/buffer.rs 0.00% <ø> (ø)
...tes/env/src/engine/experimental_off_chain/impls.rs 55.23% <0.00%> (ø)
crates/env/src/engine/off_chain/impls.rs 42.98% <0.00%> (ø)
crates/lang/src/codegen/dispatch/execution.rs 0.00% <ø> (ø)
crates/lang/codegen/src/generator/dispatch.rs 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1393502...6676c7c. Read the comment docs.

@xgreenx xgreenx force-pushed the optimizations/reworked-common-part-of-message branch from 6d1bfc8 to 7aa4234 Compare November 9, 2021 19:26
@xgreenx xgreenx force-pushed the optimizations/reworked-common-part-of-message branch from 21f5fd7 to feaf6bb Compare November 9, 2021 19:31
# Conflicts:
#	crates/lang/src/codegen/dispatch/execution.rs
@xgreenx
Copy link
Collaborator Author

xgreenx commented Nov 29, 2021

Extended version of this change in the #1017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants