Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): interact #1377

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(website): interact #1377

merged 2 commits into from
Sep 18, 2024

Conversation

nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Sep 13, 2024

I've addressed:

  • The feature for CAN-505: On the interact page, the simulate tx button should use the website provider, not the one from the wallet.
  • I've expanded the functionality not only for the simulate tx button but also for the read call
  • For read calls, I've also passed the from, when the wallet is connected.
  • I've fixed an issue with the URL, the selector was being set as undefined, and now it is using the proper selected.
  • I've added some useMemo to avoid unnecessary re-renders.

@nicosampler nicosampler self-assigned this Sep 13, 2024
Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 26488ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicosampler nicosampler requested a review from a team September 13, 2024 20:12
@mjlescano mjlescano changed the base branch from main to dev September 16, 2024 14:50
@nicosampler nicosampler merged commit 218d3af into dev Sep 18, 2024
11 of 15 checks passed
@nicosampler nicosampler deleted the fix/CAN-505 branch September 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants