Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Support --forge.* flags #1385

Merged
merged 29 commits into from
Sep 19, 2024
Merged

feat(cli): Support --forge.* flags #1385

merged 29 commits into from
Sep 19, 2024

Conversation

saeta-eth
Copy link
Contributor

@saeta-eth saeta-eth commented Sep 17, 2024

This PR adds support for the --forge.* notation in Cannon's CLI, allowing users to configure forge-specific flags more intuitively. It aligns with the existing --anvil.* flag structure to improve consistency across CLI configurations.

Usage example:

  • cannon build cannonfile.toml --forge.optimize --forge.optimizer-runs 200 --forge.use 0.8.17 --forge.out ./artifacts
  • cannon test cannonfile.toml -v --forge.vvvvv --forge.match-contract ContractTest

Closes https://linear.app/usecannon/issue/CAN-508/add-foundry-params-to-all-cannon-commands-with-forge-and-anvil

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: a571c4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth saeta-eth changed the title feat(cli): Add forge flags into Cannon feat(cli): Support --forge.* flags Sep 18, 2024
@saeta-eth saeta-eth changed the title feat(cli): Support --forge.* flags feat(cli): Support --forge.* flags Sep 18, 2024
@saeta-eth saeta-eth marked this pull request as ready for review September 18, 2024 03:10
@saeta-eth saeta-eth requested a review from a team September 18, 2024 13:53
@saeta-eth saeta-eth changed the base branch from chore/upgrade-commander to dev September 18, 2024 13:53
packages/cli/package.json Outdated Show resolved Hide resolved
packages/cli/src/rpc.ts Show resolved Hide resolved
@mjlescano
Copy link
Member

rebase with dev so the actions get executed 🙏

@saeta-eth saeta-eth merged commit b92c4b0 into dev Sep 19, 2024
6 of 8 checks passed
@saeta-eth saeta-eth deleted the add/forge-flags-cannon branch September 19, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants