Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize CI a bit #299

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Optimize CI a bit #299

merged 5 commits into from
Apr 9, 2022

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Apr 9, 2022

No description provided.

Goooler
Goooler commented Apr 9, 2022
View reviewed changes
.github/workflows/publish_release.yml
@@ -8,6 +8,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
if: github.repository == 'usefulness/easylauncher-gradle-plugin'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See square/kotlinpoet#1119.

@codecov
Copy link

codecov bot commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #299 (076ea43) into master (a11292c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage     79.80%   79.80%           
  Complexity      127      127           
=========================================
  Files            15       15           
  Lines           604      604           
  Branches         96       96           
=========================================
  Hits            482      482           
  Misses           51       51           
  Partials         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11292c...076ea43. Read the comment docs.

@Goooler
Copy link
Contributor Author

Goooler commented Apr 9, 2022 

Run actions/setup-java@v3
Trying to resolve the latest version from remote
Error: Could not find satisfied version for SemVer '15'. 
Available versions: 18.0.0+36, 17.0.2+8, 17.0.1+12, 17.0.0+35, 16.0.2+7, 11.0.14+101, 11.0.14+9, 11.0.[13](https://github.com/usefulness/easylauncher-gradle-plugin/runs/5954848046?check_suite_focus=true#step:3:13)+8, 11.0.12+7, 8.0.322+6, 8.0.312+7, 8.0.302+8

@Goooler
Copy link
Contributor Author

Goooler commented Apr 9, 2022

May we need to use java 17 or zulu?

mateuszkwiecinski
mateuszkwiecinski approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@mateuszkwiecinski mateuszkwiecinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And yes, Java 17 is fine 👌

@mateuszkwiecinski mateuszkwiecinski merged commit 1a0d48c into usefulness:master Apr 9, 2022
@Goooler Goooler deleted the ci branch April 9, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszkwiecinski mateuszkwiecinski mateuszkwiecinski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goooler @mateuszkwiecinski