Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing any _drawable_ resource, not just adaptive icon xmls #460

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

mateuszkwiecinski
Copy link
Member

@mateuszkwiecinski mateuszkwiecinski commented Jun 3, 2023

Fixes #441

@mateuszkwiecinski mateuszkwiecinski changed the title Allow passing any _drawable_ resource, not just adaptive icon resources Allow passing any _drawable_ resource, not just adaptive icon xmls Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #460 (d6a0025) into master (577091f) will decrease coverage by 0.20%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##             master     #460      +/-   ##
============================================
- Coverage     81.02%   80.82%   -0.20%     
  Complexity      114      114              
============================================
  Files            17       16       -1     
  Lines           627      631       +4     
  Branches         99      100       +1     
============================================
+ Hits            508      510       +2     
- Misses           47       49       +2     
  Partials         72       72              
Impacted Files Coverage Δ
...ct/starter/easylauncher/plugin/EasyLauncherTask.kt 76.92% <37.50%> (-6.42%) ⬇️
...ect/starter/easylauncher/plugin/IconTransformer.kt 90.38% <100.00%> (ø)
...m/project/starter/easylauncher/plugin/XmlReader.kt 72.00% <100.00%> (+4.00%) ⬆️
...ect/starter/easylauncher/plugin/models/IconFile.kt 100.00% <100.00%> (ø)

@mateuszkwiecinski mateuszkwiecinski merged commit 13487dc into master Jun 3, 2023
@mateuszkwiecinski mateuszkwiecinski deleted the updates branch June 3, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Vector icon support from Drawable not working
1 participant