Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with Java 21 #547

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Compile with Java 21 #547

merged 2 commits into from
Nov 3, 2023

Conversation

mateuszkwiecinski
Copy link
Member

@mateuszkwiecinski mateuszkwiecinski commented Oct 21, 2023

@mateuszkwiecinski mateuszkwiecinski enabled auto-merge (squash) October 21, 2023 13:23
@github-actions
Copy link

github-actions bot commented Oct 21, 2023

Diffuse output:

OLD: diffuse-base-file
NEW: android.jar

       │          compressed          │          uncompressed          
       ├──────────┬──────────┬────────┼───────────┬───────────┬────────
 JAR   │ old      │ new      │ diff   │ old       │ new       │ diff   
───────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
 class │ 58.3 KiB │ 58.1 KiB │ -222 B │ 124.9 KiB │ 124.3 KiB │ -643 B 
 other │  2.3 KiB │  2.3 KiB │    0 B │     345 B │     345 B │    0 B 
───────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
 total │ 60.6 KiB │ 60.4 KiB │ -222 B │ 125.2 KiB │ 124.6 KiB │ -643 B 

 CLASSES │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  34 │  34 │  0 (+0 -0) 
 methods │ 249 │ 247 │ -2 (+0 -2) 
  fields │  40 │  40 │  0 (+0 -0)
JAR
    compressed    │   uncompressed    │                                                                            
─────────┬────────┼──────────┬────────┤                                                                            
 size    │ diff   │ size     │ diff   │ path                                                                       
─────────┼────────┼──────────┼────────┼────────────────────────────────────────────────────────────────────────────
   3 KiB │ -221 B │  8.6 KiB │ -643 B │ ∆ com/project/starter/modules/plugins/AndroidLibraryPlugin.class           
 1.3 KiB │   -1 B │    2 KiB │    0 B │ ∆ com/project/starter/modules/plugins/AndroidLibraryPlugin_apply_1_2.class 
─────────┼────────┼──────────┼────────┼────────────────────────────────────────────────────────────────────────────
 4.3 KiB │ -222 B │ 10.6 KiB │ -643 B │ (total)
CLASSES
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   249 │ 247 │ -2 (+0 -2) 
  - com.android.build.api.dsl.LibraryDefaultConfig setTargetSdk(Integer)
  - com.android.build.api.dsl.LibraryExtension getDefaultConfig() → DefaultConfig

…ke our lives any simpler it is for some reason forbidden
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #547 (67ce0b4) into master (09718c4) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #547      +/-   ##
============================================
+ Coverage     82.07%   82.22%   +0.15%     
  Complexity       46       46              
============================================
  Files            28       28              
  Lines           541      540       -1     
  Branches         43       42       -1     
============================================
  Hits            444      444              
  Misses           74       74              
+ Partials         23       22       -1     
Files Coverage Δ
...ct/starter/modules/plugins/AndroidLibraryPlugin.kt 100.00% <ø> (+5.00%) ⬆️
...m/project/starter/quality/plugins/QualityPlugin.kt 50.00% <100.00%> (ø)

@mateuszkwiecinski mateuszkwiecinski merged commit fc166f1 into master Nov 3, 2023
28 checks passed
@mateuszkwiecinski mateuszkwiecinski deleted the updates branch November 3, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant