Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: set keycloak_frontend_url for external keycloak #682

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Sep 8, 2024

This adds the same KEYCLOAK_FRONTEND_URL variable that is used by keycloak itself to set the frontend, to inject into the API to be used in the .well-known discovery endpoint.

This adds the /auth path to this URL so that tools will be able to auto detect the correct path that keycloak is configured with correctly.

If in the future this /auth path is removed from being hardcoded as a path, tools will be able to rediscover keycloak without the relative path to /auth

@shreddedbacon
Copy link
Member Author

Probably best to merge into #684

@shreddedbacon shreddedbacon force-pushed the keycloak-realm-url branch 2 times, most recently from 1a938a2 to f73b931 Compare September 9, 2024 23:57
@tobybellwood tobybellwood changed the base branch from main to lagoon_v221 September 10, 2024 08:34
@tobybellwood tobybellwood marked this pull request as ready for review September 10, 2024 08:38
@tobybellwood tobybellwood merged commit fb3c209 into lagoon_v221 Sep 10, 2024
9 of 16 checks passed
@tobybellwood tobybellwood deleted the keycloak-realm-url branch September 10, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants