feat: use statefulset dockerhost #687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
sts-dockerhost
branch
2 times, most recently
from
479e832
to
9b87cc2
Compare
shreddedbacon
force-pushed
the
sts-dockerhost
branch
from
9b87cc2
to
721db91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the docker-host from a deployment to a statefulset.
This change also brings individual services per pod. These services will eventually be used by the
remote-controllerto distribute builds across the number of available docker-hosts, this will be used to help with queuing builds better. This statefulset should never be scaled manually, as the service per pod will only be created by helm.The service has been updated to include session affinity capability as a fall back to prevent issues in the event the docker-host replicas are scaled above 1 before the remote-controller changes roll out. This would allow for builds to sort of "round-robbin" as they're started, and that build using session affinity would always be on the docker-host it started on, but the distribution of builds may not be equal across the docker-hosts. The default replica count is still 1.
This is a drop-in replacement for the docker-host, no other changes are required to chart values to make it work. The downside is that the existing docker-host volume will be removed when this is applied, resulting in a completely fresh docker-host volume. This would result in new builds being a bit slower initially while the cache is built up.
Also updated the standalone docker-host chart to statefulset