Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a custom 404 handler, common for static rendered HTML sites #1069

Merged

Conversation

bryangruneberg
Copy link
Contributor

Having a custom 404 helper would be a convenient config file to have in the base image. I thought this might be helpful to others.

Nuxt and other static site generators render a custom 404 to /404.html by default. If the 404.html file is not found, Nginx still renders its standard boring openresty 404 so there seems to be no harm in having the default there and avoiding needing to copy it into the app's nginx dockerfile.

Thoughts?

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis looks good to me - works as expected - apps that have 404s use them, and where there isn't one, this provides it 👏

@tobybellwood tobybellwood merged commit 2f17934 into uselagoon:main Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants