Adds a custom 404 handler, common for static rendered HTML sites #1069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a custom 404 helper would be a convenient config file to have in the base image. I thought this might be helpful to others.
Nuxt and other static site generators render a custom 404 to /404.html by default. If the 404.html file is not found, Nginx still renders its standard boring openresty 404 so there seems to be no harm in having the default there and avoiding needing to copy it into the app's nginx dockerfile.
Thoughts?