Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .sql.gz to default block list for nginx-drupal #75

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Conversation

cdchris12
Copy link
Contributor

@cdchris12 cdchris12 commented Jan 18, 2021

This PR adds logic to the nginx-drupal image to automatiaclly block .sql.gz files by default.

Closes #74

@cdchris12 cdchris12 added the enhancement New feature or request label Jan 18, 2021
@cdchris12 cdchris12 self-assigned this Jan 18, 2021
@Schnitzel
Copy link
Contributor

doesn't the .*sql already match foobar.sql file?

@cdchris12
Copy link
Contributor Author

Good catch! I searched for .sql and didn't find it, so I added it as well. I'll update and remove that now.

@cdchris12 cdchris12 changed the title Add .sql and .sql.gz to default block list for nginx-drupal Add .sql.gz to default block list for nginx-drupal Jan 18, 2021
@tobybellwood tobybellwood added this to the 21.01 milestone Jan 18, 2021
@tobybellwood
Copy link
Member

I'll have a bit of a think about how best to test some of these default rules - I think we can write a testing doc that covers them, it's just where to put it!

@tobybellwood tobybellwood merged commit 6182254 into main Jan 21, 2021
@tobybellwood tobybellwood deleted the block_sql branch January 21, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database Dumps Are Not Blocked by Nginx
3 participants