Add APPEND_NATIVE_ENTRYPOINT variable to lagoon entrypoints, and use for solr9 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomoko
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the lagoon entrypoint script is run in place of the default entrypoint script in the upstream image.
In the case of Solr9, this script contained functionality that was previously in the CMD, and core creation was therefore unable to write to the var/solr directory.
This PR introduces a variable
APPEND_NATIVE_ENTRYPOINTthat when provided with a path to an entrypoint, will run that provided script after the lagoon entrypoints have concluded.Additionally, this PR utilises this functionality, and adds tests in for solr9, which had they been there in the first place, would have picked this issue up 🙈