-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Filters are reset when the page is reloaded #1820
Conversation
Has issues. Converting to draft for now, till it is resolved. |
From chat:
|
Update: The two issues attached to the restore default button after page reload have been fixed. Only the admin logout issue is left - https://ushahidi.slack.com/archives/CFC4WQG4V/p1660854328246289 |
@tuxpiper I believe that if this admin-related savedsearch logout is a problem, then it should be isolated and solved separately. I am going to conclude that this part was purposely made to behave like this (based on my re-testing of the develop branch, and also because of a certain comment I found in the code base). |
@tuxipiper @webong This is ready for review. |
@webong Could you please review? |
@webong is it feasible for you to review this? |
Tested and works great ... Good work @Ifycode @AmTryingMyBest ready for QA |
QA'd, passes. 👍 |
This pull request makes the following changes:
Testing checklist:
Ping @ushahidi/platform