Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile resolver: correct/complete oscal-version marking (spec and tool) #1313

Closed
2 of 8 tasks
wendellpiez opened this issue Jun 15, 2022 · 5 comments
Closed
2 of 8 tasks
Assignees
Labels
enhancement Epic A collection of issues to be worked on over a series of sprints Profile Resolution Issues relating to profile resolution. User Story
Milestone

Comments

@wendellpiez
Copy link
Contributor

wendellpiez commented Jun 15, 2022

User Story:

The current draft profile resolver in develop does not handle oscal-version correctly in metadata, emitting a "TODO" string.

However, the specification for the desired behavior is soft: see #1272.

We need to clarify the spec, then update the tool.

Goals:

Could be broken into the following work items:

Dependencies:

#1272

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@wendellpiez wendellpiez added enhancement User Story Profile Resolution Issues relating to profile resolution. labels Jun 15, 2022
@david-waltermire david-waltermire added the Epic A collection of issues to be worked on over a series of sprints label Jul 5, 2022
@david-waltermire david-waltermire added this to the OSCAL 1.1.0 milestone Jul 5, 2022
@wendellpiez
Copy link
Contributor Author

Proposed language for spec is in #1272.

@david-waltermire
Copy link
Contributor

@galtm This may relate to your work.

@galtm
Copy link
Contributor

galtm commented Aug 16, 2022

@galtm This may relate to your work.

If you clarify the spec, I can update the XSLT profile resolver (unless @wendellpiez prefers to do it).

@wendellpiez
Copy link
Contributor Author

wendellpiez commented Aug 16, 2022

@galtm the spec under develop should be okay see PR #1386 thanks!

I also have to make functional tests for this....

@wendellpiez
Copy link
Contributor Author

Next up:

  • Add functional unit tests for this behavior in working branch
  • Make a PR for that branch
  • Continue prep for integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Epic A collection of issues to be worked on over a series of sprints Profile Resolution Issues relating to profile resolution. User Story
Projects
Status: Done
Development

No branches or pull requests

3 participants