New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how to determine target catalog `oscal-version` #1386

Merged

david-waltermire merged 2 commits into develop from david-waltermire-nist-patch-1

Jul 25, 2022

Contributor

david-waltermire commented Jul 25, 2022 •

edited

Loading

Committer Notes

Revised text to address ambiguity around handling oscal-version in the generated catalog target based on the versions provided in the imports and source profile. Resolves #1272.

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you set "Allow edits and access to secrets by maintainers
"?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Do all automated CI/CD checks pass?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you included examples of how to use your new feature(s)?
Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

david-waltermire linked an issue

that may be closed by this pull request

Spec-Conformant Profile Resolution Tools Should Use Patch OSCAL Version, not Only Minor #1272

Closed

david-waltermire added 2 commits

July 25, 2022 12:29


          Update profile-resolution-specml.xml

5579a79

Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves #1272.


          Adding swap space to resolve memory issue with Hugo build

david-waltermire force-pushed the david-waltermire-nist-patch-1 branch from 6359a36 to 0989749 Compare

July 25, 2022 16:29

david-waltermire requested a review from wendellpiez

July 25, 2022 16:48

wendellpiez approved these changes

View reviewed changes

Contributor

wendellpiez left a comment

Nice work thanks!

david-waltermire merged commit 522e94f into develop

david-waltermire deleted the david-waltermire-nist-patch-1 branch

July 25, 2022 16:50

wendellpiez mentioned this pull request

Profile resolver: correct/complete oscal-version marking (spec and tool) #1313

Closed

8 tasks

galtm added a commit to galtm/OSCAL that referenced this pull request


          Implement opr:oscal-version function

871ecb1

This function meets the "req-meta-oscal-version" requirement
(MUST) from usnistgov#1386.

This function partially meets the "req-meta-oscalversion-error"
requirement (MAY) by checking the numeric part of the version string.
It does not check pre-release identifiers, if present in version
strings.

galtm mentioned this pull request

Implement opr:oscal-version function #1420

Merged

9 tasks

david-waltermire added a commit that referenced this pull request


          Clarify how to determine target catalog oscal-version (#1386)

9d2b6ea

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves #1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist mentioned this pull request

Bump github.com/gohugoio/hugo from 0.101.0 to 0.102.0 in /build #1433

Closed

galtm added a commit to galtm/OSCAL that referenced this pull request


          Implement opr:oscal-version and v:compare functions.

c37470f

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

david-waltermire pushed a commit that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (#1420)

b424536

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from #1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Clarify how to determine target catalog oscal-version (usnistgov#1386)

0f53028

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves usnistgov#1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit that referenced this pull request


          Clarify how to determine target catalog oscal-version (#1386)

85360e3

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves #1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (#1420)

02ab6fc

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from #1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

david-waltermire added a commit that referenced this pull request


          Clarify how to determine target catalog oscal-version (#1386)

9a73a13

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves #1272.
* Adding swap space to resolve memory issue with Hugo build

david-waltermire pushed a commit that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (#1420)

791f6b1

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from #1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Clarify how to determine target catalog oscal-version (usnistgov#1386)

c87f267

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves usnistgov#1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (usnistgov#1420)

0890e8e

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Clarify how to determine target catalog oscal-version (usnistgov#1386)

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves usnistgov#1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (usnistgov#1420)

abfe5dc

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Clarify how to determine target catalog oscal-version (usnistgov#1386)

9681a6d

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves usnistgov#1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (usnistgov#1420)

24dc16c

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Clarify how to determine target catalog oscal-version (usnistgov#1386)

0dcc243

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves usnistgov#1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (usnistgov#1420)

e5fa65f

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

aj-stein-nist modified the milestone: v1.1.0

aj-stein-nist pushed a commit to galtm/OSCAL that referenced this pull request


          Clarify how to determine target catalog oscal-version (usnistgov#1386)

a6a027f

* Revised text to address ambiguity around handling `oscal-version` in the generated catalog target based on the versions provided in the imports and source profile. Resolves usnistgov#1272.
* Adding swap space to resolve memory issue with Hugo build

aj-stein-nist pushed a commit to galtm/OSCAL that referenced this pull request


          Implement opr:oscal-version and v:compare functions. (usnistgov#1420)

c7bc009

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet