Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate diagrams for CI/CD and automatically commit them to repo #1678

Closed
2 of 5 tasks
aj-stein-nist opened this issue Mar 1, 2023 · 5 comments · Fixed by #1716
Closed
2 of 5 tasks

Generate diagrams for CI/CD and automatically commit them to repo #1678

aj-stein-nist opened this issue Mar 1, 2023 · 5 comments · Fixed by #1716
Assignees
Labels
enhancement Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. Scope: Documentation This issue relates to OSCAL documentation.

Comments

@aj-stein-nist
Copy link
Contributor

aj-stein-nist commented Mar 1, 2023

User Story

As a NIST or OSCAL community developer, in order to understand the the components of the CI/CD system in GitHub Actions, I would like an updated diagram to show the current state of CI/CD and adjust for changes.

Goals

  • Clarify current understanding of the CI/CD system with accessible diagrams as documentation
  • Maintain documentation with the least effort required over time

Dependencies

Acceptance Criteria

  • A PR integrating Compton-NIST/Inspector to run in the CI/CD process and add an updated diagram is created, reviewed, and merged.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
@aj-stein-nist aj-stein-nist added enhancement User Story Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. Scope: Documentation This issue relates to OSCAL documentation. and removed User Story labels Mar 1, 2023
@Compton-US Compton-US self-assigned this Mar 1, 2023
@aj-stein-nist
Copy link
Contributor Author

Chris briefed us during this sprint's review and will likely finish this Friday, during the very beginning of the next sprint.

Compton-US added a commit to Compton-US/OSCAL that referenced this issue Mar 17, 2023
@Compton-US
Copy link
Contributor

Compton-US commented Mar 17, 2023

@aj-stein-nist I PRed this here #1716

This is what a commit would look like (excluding the workflow file): https://github.com/Compton-NIST/OSCAL/pull/3/files
This is how it looks in the repository: https://github.com/Compton-NIST/OSCAL/tree/auto-ci-docs-update/build/ci-cd/docs

It could be more flexible for the commit/PR side, but see what we think for the content side and how it would work in the repo. Once we get it where we want it, we can add to other repos.

@aj-stein-nist aj-stein-nist linked a pull request Mar 17, 2023 that will close this issue
6 tasks
@aj-stein-nist
Copy link
Contributor Author

This came up today in standup. @aj-stein-nist owes Chris a review NLT than standup tomorrow.

@Compton-US
Copy link
Contributor

FTR: The last update to the workflow commits docs to build/ci-cd/docs

Example: https://github.com/Compton-NIST/OSCAL/tree/auto-ci-docs-update/build/ci-cd/docs

@Compton-US
Copy link
Contributor

Kind of a reminder to myself, but for future automation:

  • If someone changes a workflow and submits a PR on a feature branch...
    • Upon approval of the PR, but before merge:
      • Workflow could generate CI doc
      • What should happen next?

I don't think it can append to the PR, so this assumption is why I move to approval above.

If the docs are generated just prior to merge, is there a way to combine without having a separate pull request? If not, should it just be a pull request with a particularly named branch that is dynamically generated?

If automated, how is the target chosen? Could it be based on the approved PR target?

aj-stein-nist added a commit that referenced this issue Mar 30, 2023
* Add workflow for CI diagrams #1678

* Adjust output path

Co-authored-by: A.J. Stein <[email protected]>

* Pin action to hash.

Co-authored-by: A.J. Stein <[email protected]>

* Update to action supporting named markdown file.

* Update to latest inspector action.

* Run on feature branch pushes and place docs in build/ci-cd/docs

* Set workflow to execute on PRs opened on feature- branches in the workflows folder.

* Apply suggestions from code review

---------

Co-authored-by: A.J. Stein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. Scope: Documentation This issue relates to OSCAL documentation.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants