-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker ticket for profile resolution samples #577
Comments
@bradh I think @wendellpiez accepted all your PRs. Can you verify and check them off above? I am also working on integrating the profile resolution unit tests into the CI/CD (#561), which should cover some aspects of the "Other things we should / could do". We still need to fix the versions. |
The PRs into my repository have been merged. If all goes according to plan, corresponding failures of the current (unfinished) resolver should next emerge in unit testing (see #561), wherever @bradh has made corrections (even arguable ones) to the tests. This will give us our first set of corrections to make to the resolver, but more importantly, opportunity to flesh out and correct the relevant language in the specification. If for whatever reason the unit tests pass (call me skeptical, but maybe I messed up the PRs?) we can plunge onward to address list items and make more tests as noted. (Along with the spec work.) |
Its certainly possible I messed up the tests too - could be poor typing, or poor understanding. Concur with the opportunity to clarify (and hopefully simplify) the spec. |
March 12 Update Still pending integration work. |
Describe the bug
Profile resolution is being worked by @wendellpiez over on #559. That has some "known answer" files for the result of processing / resolving the profiles. Not all of them are necessarily correct. This ticket tracks status
Who is the bug affecting?
At this stage it only affects those working in #559. Indirectly it affects everyone who is trying to use the profile resolution logic.
What is affected by this bug?
This is a blocker to completion of #559.
When does this occur?
On resolution.
Files that are OK (per spec, noting #579 and #580)
Files needing work
href
attribute value. See Update "expected" profile resolver output for the base tests. wendellpiez/OSCAL#15abc-full-catalog.xml
rather thanabc-simple-catalog.xml
. See Fix catalog reference in loose param test profile example wendellpiez/OSCAL#13href
value (missing thecatalogs/
part). See Fix catalogs path for profile examples wendellpiez/OSCAL#12href
value (missing thecatalogs/
part). See Fix catalogs path for profile examples wendellpiez/OSCAL#12Files to be analysed
Other test profiles we might need
Other things we should / could do
The text was updated successfully, but these errors were encountered: