-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile resolution working #559
Profile resolution working #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few random comments based on a first-pass look.
@@ -0,0 +1,5 @@ | |||
--- docs/themes/uswds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think you want this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-waltermire-nist is this in the way?
|
||
* XML authoring using raw tags or alternatively, in a structured editing environment with outlining, layout, formatting and UI widgets | ||
* One-button production of a self-contained HTML file for preview in a browser | ||
* Another button for production of a version for the web site (targeting NIST/USWDS/Hugo - in development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing bracket missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded --
<p>A valid catalog must have <tgt>metadata</tgt> in addition to controls and control groups. | ||
Additionally it may have <tgt>back-matter</tgt>. How to produce and populate the | ||
<tgt>metadata</tgt> and <tgt>back-matter</tgt> is described below | ||
<revisit>link me</revisit>, as is the construction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More work on the spec is in order: this is pretty soft.
* One-button production of a self-contained HTML file for preview in a browser | ||
* Another button for production of a version for the web site (targeting NIST/USWDS/Hugo - in development | ||
* Schematron support for ad-hoc rules | ||
* Lightweight tagging is an HTML core plus a little healthy XML goodness for a few specification-oriented semantics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of this line isn't very clear. Is more about the implementation than the capability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded
|
||
So far, the Schematron performs only one test: it complains if the section numbering goes too deep. | ||
|
||
The RNC schema does introduce ID/IDREF relations, which oXygen exploits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "." at the end, otherwise it looks like the file might just have been chopped off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded
src/utils/util/resolve/punchlist.md
Outdated
|
||
Things to sketch out and test: | ||
|
||
Import with no include - implicit all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you already have this as an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now in the experimental pipeline with clearer docs.
<title>ABC Catalog</title> | ||
<last-modified>2019-11-01T10:16:22.939-04:00</last-modified> | ||
<version>1.0</version> | ||
<oscal-version>1.0-MR2</oscal-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we used 1.0.0-milestone2
in existing examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
P --> import3[Selection] | ||
import3 --> catalog.B[CPG from Catalog B] | ||
|
||
CPG is "controls, parameters and groups" remember parameters can be loose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"loose" probably needs extra explanation or cross-reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
@wendellpiez is it worth maybe including in the output catalog a reference to the profile(s) from which the catalog itself was resolved? ... i.e. a circular ref ... profile(s) > catalog (which has ref to profile(s) from which it was resolved). Otherwise, it's difficult to tell which profile(s) that a particular catalog was resolved from. |
918d284
to
2fccd6a
Compare
These are selective imports from the catalogs/abc-simple_catalog.xml, essentially identical except for how the catalog is referenced.
…le (#16) This is basically the entire catalog, except for the a1 profile. The change adds the parent groups, and the children of c1.
This is essentially the same as the catalog, and adds the parent groups to the existing result.
This adds the parent group, missing params and parts of the control.
This is basically the same as the catalog, less the children on c1
Adds the parent group and title, and missing control c3.a-1
These are essentially identical, since keep is the default.
This will be addressed by PR #624, where the commits from this PR have been rebased. Closing this PR as a result. |
Committer Notes
WIP for Profile resolution, including specification and examples.
All Submissions:
Changes to Core Features: