Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Owner, Repo Stub and Branch URLs Dynamically for Reference Model Docs for Development Snapshot #1287

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented May 25, 2022

Committer Notes

Dynamically compute remote owner and repo name stub. For the reference model documentation develop branch, we want the owner, repo name, and branch to be dynamically computed and not statically generated and presumed to be from the official main repo, usnistgov/OSCAL. Closes #1286

Development snapshot based off of running this branch locally on my workstation with hugo:

image

Main latest release:

image

Tagged release:

image

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this May 25, 2022
@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.5 milestone May 25, 2022
@aj-stein-nist aj-stein-nist marked this pull request as draft May 25, 2022 15:25
@aj-stein-nist aj-stein-nist force-pushed the 1286-development-snapshot-reference-model-docs-branch-url-assumes-origin-repo-in-all-cases branch from e975656 to 49a6b29 Compare May 25, 2022 15:38
@aj-stein-nist aj-stein-nist marked this pull request as ready for review May 25, 2022 15:39
@aj-stein-nist aj-stein-nist changed the base branch from main to release-1.0 May 25, 2022 15:48
@aj-stein-nist aj-stein-nist force-pushed the 1286-development-snapshot-reference-model-docs-branch-url-assumes-origin-repo-in-all-cases branch 2 times, most recently from ea0a6fe to 21c3c1d Compare May 25, 2022 16:23
For the reference model documentation develop branch, we want the owner, repo name, and branch
to be dynamically computed and not statically generated and presumed to be from the official
main repo, usnistgov/OSCAL. Resolves usnistgov#1286.
@aj-stein-nist aj-stein-nist force-pushed the 1286-development-snapshot-reference-model-docs-branch-url-assumes-origin-repo-in-all-cases branch from 21c3c1d to 67fdcfc Compare May 25, 2022 18:02
@aj-stein-nist
Copy link
Contributor Author

It seems we are now getting 502 blips for the GitHub URLs and those are transient, per discussion yesterday with GitHub engineers in https://github.com/github/docs/discussions/17620#discussioncomment-2812450.

@aj-stein-nist aj-stein-nist changed the base branch from release-1.0 to main May 26, 2022 17:01
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire merged commit 0816abf into usnistgov:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development Snapshot Reference Model Docs Branch URL Assumes Origin Repo in All Cases
2 participants