Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Update docs for dev env setup per usnistgov/OSCAL#1283. #1309

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jun 13, 2022

Committer Notes

Some missed bits from #1307. This PR will close #1283 once and for all.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist added Scope: Documentation This issue relates to OSCAL documentation. Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts labels Jun 13, 2022
@aj-stein-nist aj-stein-nist self-assigned this Jun 13, 2022
@aj-stein-nist
Copy link
Contributor Author

@david-waltermire-nist I am really sorry about this, I didn't circle back on this faster. I was meeting with Arminta. I did set up a clean WSL2 Ubuntu 20.04 installation (and that is more annoying than I thought), and I did notice some docs errors, but the useful bit is we missed the unzip dependency and that is kind of important.

I didn't get to mark it as draft again before you merged, apologies! 😬

@aj-stein-nist aj-stein-nist linked an issue Jun 13, 2022 that may be closed by this pull request
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts Scope: Documentation This issue relates to OSCAL documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Developer Installation Docs Are Outdated
2 participants