-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize and standardize GitHub Actions workflows #1329
Modularize and standardize GitHub Actions workflows #1329
Conversation
86169d3
to
93296f0
Compare
Talked with Dave and team during the status update. He would prefer I continue to keep it as agile and scoped as possible. He recommended and I agree to not build separate Actions in unique, independent repos and continue to move forward with reusable workflows as mentioned above, as opposed to "composite" GH Actions as an alternative. Dave also requested I keep an eye on properly handling the dependency requirements for Saxon and XML Calabash properly with Maven as just Maven and Saxon (and not their transitive deps) will not cut it. Also, Dave wants me to find a solution but also try to complete around the ETA of Tuesday (July 5th). If I can find a path forward in the short-term, worth considering it, if not, just keep current non-Maven approach. More updates to come and will resync with Dave and team accordingly. |
7d53b5b
to
1d158a3
Compare
Dave and I converged on a good |
99f11ce
to
f18a6da
Compare
Making progress on the Go bit of this from local testing and will finish clean up of that and port it to the GitHub Actions workflow now to wrap that up and finish clean up of deps and pre-req of different GHA workflows and their respective jobs. |
781ed2d
to
085e91c
Compare
I have been testing dependabot functionality and I will be removing the comment after |
ccc0a01
to
45fba90
Compare
43c7201
to
13f6c71
Compare
832673e
to
3f5a938
Compare
Wrapping up testing, seems lycheeverse/lychee#631 is not in place where I can get it to work the way I want to deprecate |
Hey @aj-stein-nist, sorry for chiming in. exclude = [
""https://defense.gov/",
"http://fedramp.gov/ns/oscal",
"https://fedramp.gov/ns/oscal",
"http://www.first.org/cvss/v2.0",
"http://www.first.org/cvss/v3.0",
"http://www.first.org/cvss/v3.1",
"https://tools.ietf.org/html.*",
"http://csrc.nist.gov/ns/.*",
"http://csrc.nist.gov/oscal",
"https://csrc.nist.gov/projects/cryptographic-module-validation-program/certificate/xxxx",
"https://cdn.telos.com/wp-content/uploads/2021/06/22150746/Xacta-360-EULA-US.pdf",
"https://search.usa.gov/search"
] At the beginning of the first line it should be one quote instead of two. 😉 It's a shot in the dark, but maybe that's what's causing the issue. Maybe you want to try that. |
Thanks, @mre. I will follow up. I did notice that typo, and got tired of waiting for latency of GH Actions, so I tested the binary locally after that fixing that typo and didn't push it up here. I just pulled the code out for now. Pushed the proper config back up though in the backup branch I made last night to handle that for later. When I run this locally in Git Bash (to be lazy) with this command and still got remap specific error around But I only tried for a bit. Will follow up later. ajs16@MYCOMPUTERNAME MINGW64 ~/code/OSCAL (1223-modularize-all-github-actions-setups-backup-lychee-config-remap-experiments)
$ lychee --config ./build/config/lychee_config.toml './**/*.md' --exclude .github
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/workflows | Excluded
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/CODEOWNERS | Excluded
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/ISSUE_TEMPLATE | Excluded
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/issue_template.md | Excluded
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/ISSUE_TEMPLATE/question.md | Excluded
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/ISSUE_TEMPLATE/feature_request.md | Excluded
? [EXCLUDED] file:///C:/Users/ajs16/code/OSCAL/.github/ISSUE_TEMPLATE/bug_report.md | Excluded
? [EXCLUDED] https://github.com/usnistgov/OSCAL/discussions/categories/q-a | Excluded
? [EXCLUDED] https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork | Excluded
? [EXCLUDED] https://github.com/usnistgov/OSCAL/blob/main/CONTRIBUTING.md | Excluded
? [EXCLUDED] https://github.com/usnistgov/OSCAL/pulls | Excluded
Error: Invalid path to URL conversion: projects |
a82099d
to
b9ed191
Compare
a12887b
to
c35b0ab
Compare
c35b0ab
to
d40327a
Compare
Committer Notes
This work closes #1223.
Improvements of note:
npm
for NodeJSpip
for Pythonmvn
andpom.xml
for Java utilitiesgo mod
or Golang method for managing thehugo-extended
dependency as wellAll Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.