-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imported-from link rel to relevant SSP assemblies #1403
Add imported-from link rel to relevant SSP assemblies #1403
Conversation
71f4454
to
3f8e1c5
Compare
OK per the updated dependencies listing, I am gonna park this until #756 is implemented and circle back to this. Moving the linked issue in the TODO column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please relocate the constraint for component/link/@rel
to the system-component
definition.
So I pushed up a separate commit 497be0d and didn't squash it yet. I understand the request, but I am not sure how this will not lead to undesirable behavior. Can you explain to me when you have a chance? If we move it here, does this not in fact allow this prop on any any component, not only a component instance in a SSP? Do we want abstracted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
The failed CI job was the link checker from cache errors with the W3C website docs, it worked after re-run. @david-waltermire-nist, per discussion during the weekly status meeting, this is ready for review. |
497be0d
to
37a6830
Compare
Also just rebased down to one commit, as the feedback concern in #1403 (review) has been explained and addressed by Dave. |
c4de2fe
to
0a6189a
Compare
@aj-stein-nist This PR needs to be rebased on the latest develop. |
37a6830
to
923fa0a
Compare
Rebased. |
36ab333
to
fcdfcdd
Compare
fcdfcdd
to
3af9f8c
Compare
1eb2bed
to
c4377f0
Compare
Also TIL |
|
02ae622
to
eeb54c1
Compare
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
60496ae
to
c3a8a9c
Compare
Rebased and waiting for pending feedback, but minor recommendation in #1403 (comment) was added before rebase. Should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Co-authored-by: David Waltermire <[email protected]> Signed-off-by: Alexander Stein <[email protected]>
Committer Notes
{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?