Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grouping construct to props for usnistgov/OSCAL#1064. #1412

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Aug 12, 2022

Committer Notes

Closes #1064.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this Aug 12, 2022
@aj-stein-nist aj-stein-nist added the Scope: Modeling Issues targeted at development of OSCAL formats label Aug 12, 2022
@aj-stein-nist aj-stein-nist linked an issue Aug 12, 2022 that may be closed by this pull request
7 tasks
@aj-stein-nist aj-stein-nist marked this pull request as ready for review August 12, 2022 18:20
@aj-stein-nist aj-stein-nist force-pushed the 1064-grouping-of-properties-in-oscal-documents-other-than-catalog branch 3 times, most recently from d3b6976 to d51d186 Compare August 12, 2022 19:37
@aj-stein-nist aj-stein-nist force-pushed the 1064-grouping-of-properties-in-oscal-documents-other-than-catalog branch from d51d186 to 907556a Compare August 12, 2022 19:46
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire merged commit 2743632 into usnistgov:develop Aug 21, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Oct 6, 2022
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Modeling Issues targeted at development of OSCAL formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping of Properties in OSCAL documents other than Catalog
2 participants