Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile alter model adjustments #1418

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Profile alter model adjustments #1418

merged 3 commits into from
Aug 17, 2022

Conversation

david-waltermire
Copy link
Contributor

Committer Notes

Work towards addressing usnistgov/liboscal-java#46.

  • Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.

    • Enumerated the set of target item types for remove.
    • Fixed references to use current by- syntax.

  • Adjusted unit tests to support better add/remove testing.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire
- Adjusted the profile metaschema to refactor the alter assemblies in…
ddec12d 
… a backwards-compatible way.

  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
@david-waltermire david-waltermire merged commit 40b728e into develop Aug 17, 2022
@david-waltermire david-waltermire deleted the profile-alter-adjustments branch August 17, 2022 18:49
david-waltermire added a commit that referenced this pull request Aug 23, 2022
@david-waltermire
Profile alter model adjustments (#1418)
8c3e916 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Oct 6, 2022
@david-waltermire @aj-stein-nist
Profile alter model adjustments (usnistgov#1418)
b182268 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
aj-stein-nist pushed a commit that referenced this pull request Oct 18, 2022
@david-waltermire @aj-stein-nist
Profile alter model adjustments (#1418)
f038975 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
david-waltermire added a commit that referenced this pull request Oct 31, 2022
@david-waltermire
Profile alter model adjustments (#1418)
68b289d 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023
@david-waltermire @aj-stein-nist
Profile alter model adjustments (usnistgov#1418)
b413079 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023
@david-waltermire @aj-stein-nist
Profile alter model adjustments (usnistgov#1418)
796e67e 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
@david-waltermire @aj-stein-nist
Profile alter model adjustments (usnistgov#1418)
a789526 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
@david-waltermire @aj-stein-nist
Profile alter model adjustments (usnistgov#1418)
b972ec3 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
aj-stein-nist pushed a commit to galtm/OSCAL that referenced this pull request Sep 28, 2023
@david-waltermire @aj-stein-nist
Profile alter model adjustments (usnistgov#1418)
9d8314f 
* - Adjusted the profile metaschema to refactor the alter assemblies in a backwards-compatible way.
  - Enumerated the set of target item types for remove.
  - Fixed references to use current `by-` syntax.
- Adjusted unit tests to support better add/remove testing.
* Updated to latest metaschema development version
* added default value `ending` for `add/@position`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendellpiez wendellpiez Awaiting requested review from wendellpiez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@david-waltermire @aj-stein-nist