-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprint24 model enhancements #516
Sprint24 model enhancements #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look right to me. I'd like to have @brianrufgsa also review before accepting this PR.
@wendellpiez Please rebase this branch against master. |
1806d93
to
e6f0969
Compare
Now rebased against latest this a.m. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to meet the minimum requirement of Issue #511 by adding the @id-ref attribute to the add assembly. It appears the @position attribute has also be constrained to "before", "after", "starting", "ending" (consistent with our documentation), and is still available in cooperation with the new @id-ref.
@brianrufgsa can we confer on this? Not sure we are looking at the same thing. I see both |
Oh I see, @brianrufgsa there's a typo in your comment I think we're actually okay. Of course now I have pushed again we need to review the PR again (sorry). heads-up @david-waltermire-nist I added a bit more to the schema docs. |
This PR also addresses #499 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment from my review performed on 11/21.
…talog metaschema). usnistgov#499.
…nk` and `base64`
402fa43
to
16c3b43
Compare
Committer Notes
Addressing #499 and #511.
All Submissions:
Changes to Core Features:
n/a - all changes are backward-compatible
n/a - self-explanatory