Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alter set-parameter, add, and remove functions #56

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Aug 17, 2022

Committer Notes

  • Added support for OSCAL profile alter statements supporting set-parameter, add, and remove functions.
  • Refactored build to eliminate extraneous dependencies.
  • Updated to latest OSCAL development build.
  • Setup auto-service generation for OSCAL Metapath function extensions.

Resolves #46.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@david-waltermire david-waltermire linked an issue Aug 17, 2022 that may be closed by this pull request
5 tasks
@david-waltermire david-waltermire marked this pull request as draft August 17, 2022 19:03
…meter`, `add`, and `remove` functions.

Refactored build to eliminate extraneous dependencies.
Updated to latest OSCAL development build.
Setup auto-service generation for OSCAL Metapath function extensions.
@david-waltermire david-waltermire marked this pull request as ready for review August 17, 2022 20:28
@david-waltermire david-waltermire merged commit f762ab8 into usnistgov:develop Aug 17, 2022
@david-waltermire david-waltermire deleted the support-alter branch August 17, 2022 20:28
@david-waltermire
Copy link
Collaborator Author

The cli-core-0.2.0-SNAPSHOT-oscal-cli.zip is an interim build that fixes this issue.

@aj-stein-nist
Copy link
Collaborator

The cli-core-0.2.0-SNAPSHOT-oscal-cli.zip is an interim build that fixes this issue.

Do we want to join forces and further integrate the WIP testing harness or leave it out of band? I can touch up and help test the interim build, lemme know!

aj-stein-nist added a commit to aj-stein-nist/oscal-cli-tests that referenced this pull request Aug 19, 2022
@david-waltermire
Copy link
Collaborator Author

Here is another interim build that fixes a few null pointer exceptions caused by invalid id references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for profile alter statements in profile resolution
2 participants