Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align metaschema-xslt with metaschema core #50

Conversation

nikitawootten-nist
Copy link
Collaborator

@nikitawootten-nist nikitawootten-nist commented Jul 24, 2023

Committer Notes

Several key commits, namely 13cde791af0dc8682f7dd1532e36205ce968e20d (usnistgov/metaschema#384) and a36f579e1e30abb2263895242cdbd2cf4bd29513 (usnistgov/metaschema#380), were made after the metaschema-xslt migration. This PR aligns the new repository with these changes.

Also, this PR changes the filenames generated by the converter scripts to align with the ones previously used in the OSCAL repo.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

nikitawootten-nist and others added 2 commits July 24, 2023 13:10
Upstream commits:
13cde791af0dc8682f7dd1532e36205ce968e20d and a36f579e1e30abb2263895242cdbd2cf4bd29513

Co-authored-by: Kyle Laker <[email protected]>
Co-authored-by: Alexander Stein <[email protected]>
@nikitawootten-nist nikitawootten-nist requested a review from a team as a code owner July 24, 2023 17:36
@nikitawootten-nist nikitawootten-nist changed the title [DRAFT] Align metaschema-xslt with metaschema core Align metaschema-xslt with metaschema core Jul 24, 2023
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have some flakey test problems as discussed in Gitter but changes pulled in look good.

@nikitawootten-nist nikitawootten-nist merged commit 8e148dc into usnistgov:develop Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants