Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to runtime interfaces for content converter XSLTs #174

Closed
3 tasks
wendellpiez opened this issue Sep 16, 2021 · 2 comments · Fixed by #176
Closed
3 tasks

Enhancements to runtime interfaces for content converter XSLTs #174

wendellpiez opened this issue Sep 16, 2021 · 2 comments · Fixed by #176
Labels
enhancement New feature or request

Comments

@wendellpiez
Copy link
Collaborator

User Story:

Prompted by discussions related to usnistgov/OSCAL#1020, there are a couple of enhancements we can consider to the XML-to-JSON and JSON-to-XML converters in the XSLT-M4 implementation, to make them more robust and easier to use.

Goals:

  • better support for error conditions with configuration / resource acquisition
    • including if the wrong converter is called by mistake for the provided data (source)
  • exposing a json-data parameter to pass in literal JSON instead of a file reference

Dependencies:

This can happen along with any bug repair / testing work.

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated. Changes to the website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@wendellpiez wendellpiez added the enhancement New feature or request label Sep 16, 2021
@wendellpiez
Copy link
Collaborator Author

Also consider putting templates in both stylesheets into (default) modes; currently because both directions are implemented in template sets in no-mode, they cannot be imported into the same XSLT cleanly.

@wendellpiez
Copy link
Collaborator Author

Also better stress testing of runtimes and error reporting (evaluation of text value templates etc.)

wendellpiez added a commit to wendellpiez/metaschema that referenced this issue Sep 27, 2021
…time interfaces of generated JSON and XML converters
wendellpiez added a commit to wendellpiez/metaschema that referenced this issue Nov 12, 2021
…late priority setting to intervene over template clashes usnistgov#174
@wendellpiez wendellpiez linked a pull request Nov 16, 2021 that will close this issue
8 tasks
david-waltermire pushed a commit that referenced this issue Nov 17, 2021
* Addressing #174 cf also usnistgov/OSCAL#1020 - adjusting runtime interfaces of generated JSON and XML converters
* Adding support for passing in JSON literal (to be tested); added template priority setting to intervene over template clashes #174
* Updating tests
* Correcting omission resulting in redundant path expressions (same step expressed multiply); tests; refinement of path matching to distinguish between flag matches signaled by 'attribute::' axis, vs field or assembly matches via 'child::' (or implicit) axis. With tests over current OSCAL SSP model.
* Touchups to unit tests
* Updated readme on OSCAL metaschema examples
@david-waltermire david-waltermire added this to the Metaschema 0.9.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants