Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness of the RFC3339 RegEx in OSCAL Json Schema #224

Closed
hahsan-ti opened this issue Jul 29, 2022 · 9 comments · Fixed by #229
Closed

Correctness of the RFC3339 RegEx in OSCAL Json Schema #224

hahsan-ti opened this issue Jul 29, 2022 · 9 comments · Fixed by #229
Assignees
Labels
question Further information is requested

Comments

@hahsan-ti
Copy link

Question

The regular expression used for the datetime fields may not be correct. The pattern is complex as it attempts to cover different date combinations. In the complexity of the pattern, I have noticed the following issues:

  1. The timestamp is not recognized if the date falls in January, February, March, May, July, August, October, and December.
  2. Two backslashes \\ symbols prefix the period separating the sub-seconds from seconds.
  3. The time offset from UTC can range from -99:99 to +99:99, where it should be between -12:00 to +14:00. A timezone offset of more than ±24:00 will put you on a different day.

RegEx from OSCAL POA&M Schema (1.0.4)

^((2000|2400|2800|(19|2[0-9](0[48]|[2468][048]|[13579][26])))-02-29)|(((19|2[0-9])[0-9]{2})-02-(0[1-9]|1[0-9]|2[0-8]))|(((19|2[0-9])[0-9]{2})-(0[13578]|10|12)-(0[1-9]|[12][0-9]|3[01]))|(((19|2[0-9])[0-9]{2})-(0[469]|11)-(0[1-9]|[12][0-9]|30))T(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\\.[0-9]+)?(Z|[+-][0-9]{2}:[0-9]{2})$

You can see this regex in action here.

I am unsure if any of the above are actual problems or if I need to learn more. However, if I have identified issues, then I propose the following solution.

The first issue is missing parentheses to group the regex for the dates. Adding the parentheses groups the appropriate or together. The second issue is caused by an extra backslash that must be removed. The last issue may be addressed -- if desired -- by expanding the regex to consider all time offsets as they exist at the time of the release.

^(((2000|2400|2800|(19|2[0-9](0[48]|[2468][048]|[13579][26])))-02-29)|(((19|2[0-9])[0-9]{2})-02-(0[1-9]|1[0-9]|2[0-8]))|(((19|2[0-9])[0-9]{2})-(0[13578]|10|12)-(0[1-9]|[12][0-9]|3[01]))|(((19|2[0-9])[0-9]{2})-(0[469]|11)-(0[1-9]|[12][0-9]|30)))T(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\.[0-9]+)?(Z|(\-((0[0-9]|1[0-2]):00|0[39]:30)|\+((0[0-9]|1[0-4]):00|(0[34569]|10):30|(0[58]|12):45)))$

You can see this regex in action here.

Also, why shouldn't we support a leap second?

@hahsan-ti hahsan-ti added the question Further information is requested label Jul 29, 2022
@GaryGapinski
Copy link

There is an additional interoperability consideration: in an XML Schema dateTime the fractional second string must not end in '0'.

(\.[0-9]+)? should possibly be (\.[0-9]*[1-9])?.

Bonus: I just used an XPath (3.1 in XML Editor 24.1, build 2022062007) statement current-dateTime() to generate a sample dateTime and received 2022-07-30T08:45:27.015550-04:00: go figure.

@michaelhkay
Copy link

The rule cited from XML Schema relates to the "canonical representation" - the implication is that the trailing zero carries no information and will be lost when round-tripping, not that it is disallowed. The XPath rules for conversion of a dateTime to a string (which presumably apply to the case you are describing, though you haven't described it in any detail) handle the seconds part using the rules for xs:decimal to string conversion, which refer to the XSD rules for the canonical representation of xs:decimal values, which prohibit the trailing zero in your example: it looks like what you've described is non-conformant as the output of xs:dateTime to string conversion, though it would of course be conformant as the input.

@david-waltermire
Copy link
Collaborator

If I am interpreting @michaelhkay correctly, having a more restrictive pattern that enforces trimming the trailing 0s would be ok and we should expect XML tools to produce trimmed time values for fractional seconds. Is this correct?

If correct, I believe the updated pattern should be:

^(((2000|2400|2800|(19|2[0-9](0[48]|[2468][048]|[13579][26])))-02-29)|(((19|2[0-9])[0-9]{2})-02-(0[1-9]|1[0-9]|2[0-8]))|(((19|2[0-9])[0-9]{2})-(0[13578]|10|12)-(0[1-9]|[12][0-9]|3[01]))|(((19|2[0-9])[0-9]{2})-(0[469]|11)-(0[1-9]|[12][0-9]|30)))T(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\.[0-9]*[1-9])?(Z|(\-((0[0-9]|1[0-2]):00|0[39]:30)|\+((0[0-9]|1[0-4]):00|(0[34569]|10):30|(0[58]|12):45)))$

You can see this regex in action here.

@GaryGapinski
Copy link

If I am interpreting @michaelhkay correctly, having a more restrictive pattern that enforces trimming the trailing 0s would be ok and we should expect XML tools to produce trimmed time values for fractional seconds. Is this correct?

After a bit of testing (using the following) I found that an xs:dateTime variable will serialize without a trailing zero.
It also shows that '2022-08-02T12:31:42.339230Z' castable as xs:dateTime returns true.

<?xml version="1.0" encoding="UTF-8"?>
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:xs="http://www.w3.org/2001/XMLSchema" exclude-result-prefixes="xs"
    expand-text="true" version="3.0">
    <xsl:output method="xml" omit-xml-declaration="true" />
    <xsl:variable name="UTC" as="xs:duration" select="xs:dayTimeDuration('PT0H')" />
    <xsl:variable name="UTC-date" as="xs:date" select="adjust-date-to-timezone(current-date(), $UTC)" />
    <xsl:variable name="UTC-datetime" as="xs:dateTime" select="adjust-dateTime-to-timezone(current-dateTime(), $UTC)" />
    <xsl:template match="/">
        <dateTime test="{'2022-08-02T12:31:42.339230Z' castable as xs:dateTime}">
            <xsl:copy-of select="$UTC-datetime" />
        </dateTime>
    </xsl:template>
</xsl:stylesheet>

When XML, JSON, and YAML are employed, perhaps the canonical form should be enforced. That would provide assurance of equality when (untyped) strings were compared.

@david-waltermire
Copy link
Collaborator

We need to first create a PR in develop updating the data types.

@david-waltermire david-waltermire transferred this issue from usnistgov/OSCAL Aug 16, 2022
@michaelhkay
Copy link

michaelhkay commented Aug 16, 2022 via email

@aj-stein-nist
Copy link
Collaborator

Is a regular expression really the most effective specification tool for this task? Michael Kay Saxonica

Is there an implied alternative in the question? :-)

@michaelhkay
Copy link

michaelhkay commented Aug 16, 2022 via email

@david-waltermire
Copy link
Collaborator

Issue #230 identifies follow on work to update the data type documentation. This should include clarifying behavior per @michaelhkay.

david-waltermire added a commit to usnistgov/OSCAL that referenced this issue Sep 27, 2022
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for #1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this issue Sep 27, 2022
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist added a commit to usnistgov/OSCAL that referenced this issue Oct 18, 2022
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for #1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit to usnistgov/OSCAL that referenced this issue Oct 31, 2022
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for #1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this issue Dec 7, 2022
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 9, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 10, 2023
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Feb 6, 2023
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
david-waltermire added a commit that referenced this issue Mar 9, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/OSCAL that referenced this issue Jun 29, 2023
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov/OSCAL#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/OSCAL that referenced this issue Jun 29, 2023
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov/OSCAL#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jul 10, 2023
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
aj-stein-nist added a commit to galtm/OSCAL that referenced this issue Sep 28, 2023
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Rene Tshiteya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants