Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamping JSON Schema definitions with unique IDs #111

Closed

Conversation

wendellpiez
Copy link
Collaborator

Committer Notes

Reports indicate that not all JSON Schema validation engines are tolerant of context-dependent definition names; they have to be globally unique so we get errors for multiple definitions of (say) #/definitions/title when a metaschema source has multiple local definitions for assemblies or fields of that name.

This patch addresses this by adding an (arbitrary) generated identifier to stamp each definition with an identifier peculiar to its origin in the source.

Needs testing.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass? ? (let's check?)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@wendellpiez
Copy link
Collaborator Author

Closing this PR in favor of a new one targeting this branch: https://github.com/wendellpiez/metaschema/tree/issues-84-114-schemagen-revamp

david-waltermire pushed a commit that referenced this pull request Feb 11, 2021
@wendellpiez wendellpiez deleted the json-schema-bugfix-dec2020a branch March 4, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant