Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairs and new features for schema and converter generators #119

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

wendellpiez
Copy link
Collaborator

Schemas and converter generators have been refurbished and tested with more extreme cases of valid Metaschema imports.

This PR will address at least usnistgov/OSCAL#829 usnistgov/OSCAL#792 #66 #49

Includes:

  • Better represention of EMPTY elements (as assemblies not a datatype)
  • Support for ANY in the XSD production and JSON Schema production ("additionalProperties"=true)
  • Aliasing - different names for the same type
  • Homonymy - different types with the same name

Committer Notes

Integration testing over a much wider range of samples is working.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? All changes are in keeping with stipulated Metaschema semantics
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

…pleting feature extension work related to aliasing types, inline definitions, ANY models, representation of `empty` etc. with assorted bug fixes; new prose model
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Required Flag Handled Differently XML vs. Json Support empty assemblies instead of an 'empty' datatype
2 participants