Repair to (JSON) schema generation bug on module-local flag definition #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Addresses the bug reported by @tcorsa on usnistgov/OSCAL#844.
PR #125 claims falsely to have remedied this bug, but it was a false report - test data in that branch does not expose it.
The problem was that the filter that collects and reconciles metaschema modules was failing to resolve fully (and rewrite) the links from flag invocations to their (local) definitions, leading to data lapse in subsequent phases. We had this working for assemblies and fields but not flags.
All Submissions:
Changes to Core Features:
n/a - no changes to core features