Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to metaschema processing regression exposed by docs glitch #167

Conversation

wendellpiez
Copy link
Collaborator

The symptom of the problem (introduced yesterday) is broken links in the generated documentation (on some inputs) along with glitchy presentation of the JSON tree -- grouping is off and group names are dropped.

This is due to a failure in the process that generates the abstract instance representation from the metaschema, made yesterday and not discovered till this morning. Because a parameter was renamed at only one end, node identifiers were not being propagated from references to the definitions they referenced.

Committer Notes

This PR brings us back to stable with both conversions and docs.

NB testing is in order (I will also continue testing).

We could also do more cleanup (see #164) and build out more testing (#163) before merging.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, tests, and the cleanup!

@david-waltermire david-waltermire merged commit 78c29f4 into usnistgov:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants