Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from CircleCI to GitHub Actions #204

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Migrate from CircleCI to GitHub Actions #204

merged 1 commit into from
Apr 28, 2022

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Apr 12, 2022 •
edited
Loading

Committer Notes

This PR will add one or more GitHub Action workflows, and the jobs that comprise them, to replace and deprecate the use of CircleCI for this repository. This PR closes #200 and closes #192.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you included examples of how to use your new feature(s)?
  • Have you written new tests for your core changes, as applicable?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this Apr 12, 2022
@aj-stein-nist
Copy link
Collaborator Author

@david-waltermire-nist, I will test on my fork by relaxing the filter for now, but do I need to request NIST MML staff that maintain our GitHub org enable it for this repo or are you able to do so for this repo by yourself as an admin?

@aj-stein-nist
Copy link
Collaborator Author

Also, @david-waltermire-nist, it seems master and develop are aligned with each other for now, but where do you want this PR to target? I know GHA gets very weird with rolling out CI/CD updates until they are merged into master (unless configured otherwise), so I will point it to there unless you ask for otherwise. Let me know!

@aj-stein-nist aj-stein-nist force-pushed the issue-200-migrate-circle-to-gha branch from 23ac3da to 65ce435 Compare April 12, 2022 18:01
@aj-stein-nist
Copy link
Collaborator Author

Making some more progress, but I am not sure why hugo is missing some pieces of the site. Will have to troubleshoot tomorrow and potentially pair with the rest of the dev team.

image

@aj-stein-nist aj-stein-nist force-pushed the issue-200-migrate-circle-to-gha branch from 9744c7c to d663f77 Compare April 13, 2022 02:44
@aj-stein-nist
Copy link
Collaborator Author

aj-stein-nist commented Apr 13, 2022 •
edited
Loading

Meeting with Dave later today to cover some of this stuff and get it ready for formal review. Haven't figured out the disparities with the website generation steps, but if it is submodule-based, I am sure I will hear about it. 😝

@aj-stein-nist aj-stein-nist force-pushed the issue-200-migrate-circle-to-gha branch from 510169a to 39cf280 Compare April 13, 2022 22:02
@aj-stein-nist
Copy link
Collaborator Author

Making some more progress, but as of current builds it seems whatever gets built by hugo is not detected as changed by git after the build, not sure why.

@aj-stein-nist aj-stein-nist force-pushed the issue-200-migrate-circle-to-gha branch from 20b56f6 to 276c44c Compare April 16, 2022 01:41
@aj-stein-nist aj-stein-nist changed the title [WIP] Migrate from CircleCI to GitHub Actions Migrate from CircleCI to GitHub Actions Apr 16, 2022
@aj-stein-nist aj-stein-nist force-pushed the issue-200-migrate-circle-to-gha branch 2 times, most recently from eabbdf7 to 25819a2 Compare April 16, 2022 02:09
@aj-stein-nist aj-stein-nist marked this pull request as ready for review April 16, 2022 02:10
@aj-stein-nist
Copy link
Collaborator Author

@david-waltermire-nist ok I finished touch-ups after today's pairing session. It is ready for final review.

This was referenced Apr 18, 2022
Merged
Closed
Closed
Merged
@aj-stein-nist
Deprecate Circle for GitHub Actions, refactor CI/CD.
4641fdf 
Change lychee configuration location per Dave's feedback.
@aj-stein-nist aj-stein-nist force-pushed the issue-200-migrate-circle-to-gha branch from 25819a2 to 4641fdf Compare April 20, 2022 22:43
@aj-stein-nist
Copy link
Collaborator Author

OK, @david-waltermire-nist, this should be ready ready this time. One last bit we discussed about relocating the .lycheeignore from the repo root directory to the newly created ./build/config dir, to match OSCAL, and place alongside the ./build/config/.markdown-link-check configuration is now added and I squashed the commit. Once this is merged, I will implement elsewhere as agreed.

david-waltermire
david-waltermire approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire merged commit 54bbcdf into usnistgov:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees

@aj-stein-nist aj-stein-nist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port CI/CD from CircleCI to GitHub Actions Outdated Links on the Using Metaschema Page
2 participants
@aj-stein-nist @david-waltermire