Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairing JSON Schema generation #208

Merged

Conversation

wendellpiez
Copy link
Collaborator

@wendellpiez wendellpiez commented May 12, 2022

Addresses usnistgov/OSCAL#1260.

In this version we aligned datatypes in both XML and JSON with new type definitions. In doing so we were also relocating resources. These two initiatives (targeting different releases) were confused and a necessary file was mistakenly deleted.

CI/CD failed to catch that the JSON Schemas that result, are inoperative (indeed, throw errors as reported).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

@david-waltermire david-waltermire merged commit 99144ce into usnistgov:main May 12, 2022
david-waltermire added a commit to usnistgov/OSCAL that referenced this pull request May 12, 2022
david-waltermire added a commit to usnistgov/OSCAL that referenced this pull request May 12, 2022
david-waltermire added a commit to usnistgov/OSCAL that referenced this pull request May 12, 2022
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants