Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Mark Recursive Assemblies Empty in Doc Generation #234

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Don't Mark Recursive Assemblies Empty in Doc Generation #234

merged 1 commit into from
Sep 19, 2022

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Sep 6, 2022 •
edited
Loading

Committer Notes

Closes #225.

Example screenshots of updated website reflecting this change are below.

image

image

On my fork of OSCAL with sub-module updates and PR branch overwritten with a push to fork's main branch for this review, CI/CD workflows run, and potentially updated website generated for quick review, see below.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@aj-stein-nist aj-stein-nist added the documentation Improvements or additions to documentation label Sep 6, 2022
@aj-stein-nist aj-stein-nist changed the base branch from main to develop September 6, 2022 21:11
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Sep 6, 2022
@aj-stein-nist
Test submodule on fork with usnistgov/metaschema#234
2462e71
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Sep 6, 2022
@aj-stein-nist
Test submodule on fork with usnistgov/metaschema#234
d362458
@aj-stein-nist aj-stein-nist marked this pull request as ready for review September 6, 2022 21:53
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty
bd0fbb0 
See more details about analysis and PR changes below:

usnistgov#225 (comment)
usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
@aj-stein-nist aj-stein-nist force-pushed the 225-metaschema-doc-generator-marks-certain-assemblies-empty-when-they-arent branch from 18c946c to bd0fbb0 Compare September 6, 2022 22:23
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Sep 6, 2022
@aj-stein-nist
Test submodule on fork with usnistgov/metaschema#234
aabdd96
@david-waltermire david-waltermire merged commit 9686b09 into usnistgov:develop Sep 19, 2022
@aj-stein-nist aj-stein-nist mentioned this pull request Sep 19, 2022
Merged
6 tasks
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Oct 6, 2022
@aj-stein-nist
Test submodule on fork with usnistgov/metaschema#234
5a93bbc
david-waltermire pushed a commit that referenced this pull request Dec 7, 2022
@aj-stein-nist @wendellpiez @david-waltermire
In model doc gen, do not mark recursive assemblies empty (#234)
7f4571b 
See more details about analysis and PR changes below:

#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 9, 2023
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty (usnistgov#234)
1b6ad01 
See more details about analysis and PR changes below:

usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty (usnistgov#234)
f06cbaa 
See more details about analysis and PR changes below:

usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty (usnistgov#234)
de93dd3 
See more details about analysis and PR changes below:

usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty (usnistgov#234)
0e18fe4 
See more details about analysis and PR changes below:

usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty (usnistgov#234)
8153513 
See more details about analysis and PR changes below:

usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@aj-stein-nist @wendellpiez
In model doc gen, do not mark recursive assemblies empty (usnistgov#234)
10cd195 
See more details about analysis and PR changes below:

usnistgov#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
david-waltermire pushed a commit that referenced this pull request Mar 9, 2023
@aj-stein-nist @wendellpiez @david-waltermire
In model doc gen, do not mark recursive assemblies empty (#234)
c1c6e4c 
See more details about analysis and PR changes below:

#225 (comment)

Co-authored-by: Wendell Piez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees

@wendellpiez wendellpiez

@aj-stein-nist aj-stein-nist

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metaschema Doc Generator Marks Certain Assemblies Empty When They Aren't
3 participants
@aj-stein-nist @david-waltermire @wendellpiez