Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allowed-values docs and explain default value #251

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Nov 5, 2022

Committer Notes

Resolves #248.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@aj-stein-nist aj-stein-nist added the documentation Improvements or additions to documentation label Nov 5, 2022
@aj-stein-nist aj-stein-nist self-assigned this Nov 5, 2022
@aj-stein-nist aj-stein-nist force-pushed the 248-clarify-default-value-allow-values-constraints branch 2 times, most recently from a10aff5 to 3a01b9b Compare November 5, 2022 01:00
@aj-stein-nist aj-stein-nist force-pushed the 248-clarify-default-value-allow-values-constraints branch from 3a01b9b to ae3f2fe Compare November 5, 2022 01:01
@aj-stein-nist
Copy link
Collaborator Author

@david-waltermire-nist, per discussion today, this one's ready to go!

Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I provided a quick adjustment. I'll approve if you don't agree.

website/content/specification/syntax/_index.md Outdated Show resolved Hide resolved
@david-waltermire david-waltermire merged commit 529ff85 into usnistgov:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify Default Value for Enumerations of Allowed Values Constraints for Metaschema Syntax
2 participants