Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to support corrected JSON Schema Generation PR #380

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Update tests to support corrected JSON Schema Generation PR #380

merged 2 commits into from
Jun 26, 2023

Commits on Jun 15, 2023

  1. Correct field and flag enumerations in JSON schemas. 

    Previously in usnistgov#360, @kylelaker reported a needed
improvement to fix a regression for usnistgov/OSCAL#1773. While I had
been completing testing in usnistgov#360 and properly expanding test coverage to
address how we handle enumerations based on allow-other and target
attributes for field and flag elements in Metaschema (both act similarly
but subtly different with more scenarios for field), I observed my test data
instances needed further correction in a way that cannot be address in the
PR by Kyle. This merges the changes from the commit reffed by the URL
below, adds my enhancement, tests, and all examples that helped me
uncover missing code.

usnistgov@6fb8a74

Co-authored-by: Kyle Laker <[email protected]>
    @aj-stein-nist @laurelmay
    aj-stein-nist and laurelmay committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a25c688 View commit details
    Browse the repository at this point in the history

  2. Surpress bottlecaps.de link fail 

    More info below:
https://github.com/usnistgov/metaschema/actions/runs/5228171226/jobs/9440341454
    @aj-stein-nist
    aj-stein-nist committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a876629 View commit details
    Browse the repository at this point in the history