Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial for expect #530

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Tutorial for expect #530

merged 7 commits into from
Feb 21, 2024

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Feb 2, 2024 •
edited
Loading

Committer Notes

Closes #527.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? Yes, in related issue.
  • Have you included examples of how to use your new feature(s)? Yes, this website change is a tutorial inherently demonstrating a series of examples.
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.
  • Have you written new tests for your core changes, as applicable? N/A website change

@aj-stein-nist aj-stein-nist self-assigned this Feb 2, 2024
@aj-stein-nist aj-stein-nist changed the base branch from main to develop February 2, 2024 22:42
@aj-stein-nist aj-stein-nist force-pushed the 527-tutorial-for-expect-and-matches branch 2 times, most recently from 266c6e6 to f16ea62 Compare February 5, 2024 14:50
@aj-stein-nist
Copy link
Collaborator Author

aj-stein-nist commented Feb 5, 2024 •
edited
Loading

Website builds are going to fail until tutorial 2 in #508 is merged (it's been reviewed informally during successive community calls and Dave's feedback has been addressed, but I have triage perms and cannot merge it into develop).

/cc @david-waltermire

@aj-stein-nist aj-stein-nist mentioned this pull request Feb 6, 2024
Closed
@aj-stein-nist aj-stein-nist force-pushed the 527-tutorial-for-expect-and-matches branch 2 times, most recently from 243639a to f41abbf Compare February 7, 2024 15:07
@aj-stein-nist aj-stein-nist mentioned this pull request Feb 7, 2024
Closed
@david-waltermire david-waltermire added this to the Metaschema 1.0.0 milestone Feb 9, 2024
@aj-stein-nist aj-stein-nist force-pushed the 527-tutorial-for-expect-and-matches branch 6 times, most recently from 62618b6 to ef34fa4 Compare February 14, 2024 03:35
@aj-stein-nist aj-stein-nist marked this pull request as ready for review February 14, 2024 03:36
@aj-stein-nist aj-stein-nist force-pushed the 527-tutorial-for-expect-and-matches branch from ef34fa4 to 5e38383 Compare February 14, 2024 03:37
david-waltermire
david-waltermire suggested changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good. I requested some minor changes to improve the text.

@aj-stein-nist
Copy link
Collaborator Author

aj-stein-nist commented Feb 14, 2024 •
edited
Loading

This is very good. I requested some minor changes to improve the text.

I hope the upcoming matches tutorial matches expectations.

(I'll see myself out. 🚪 🚶)

@aj-stein-nist aj-stein-nist changed the title Tutorial for expect and matches Tutorial for expect Feb 14, 2024
@aj-stein-nist aj-stein-nist force-pushed the 527-tutorial-for-expect-and-matches branch from 7719523 to e6089a3 Compare February 16, 2024 22:11
david-waltermire
david-waltermire approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the great and hard work on this!

@david-waltermire david-waltermire added this pull request to the merge queue Feb 21, 2024
Merged via the queue into usnistgov:develop with commit 2493f7e Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

@Arminta-Jenkins-NIST Arminta-Jenkins-NIST Awaiting requested review from Arminta-Jenkins-NIST

Assignees

@aj-stein-nist aj-stein-nist

Labels
None yet
Projects
None yet
Milestone
Metaschema 1.0.0 Milestone 1
Development

Successfully merging this pull request may close these issues.

Tutorial for expect
2 participants
@aj-stein-nist @david-waltermire