Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting conversion glitches in SP800-53A content #143

Merged
merged 8 commits into from
Sep 23, 2022

Conversation

wendellpiez
Copy link
Contributor

@wendellpiez wendellpiez commented Sep 19, 2022

Committer Notes

Issue #101 identified some errors in data conversion of SP 800-53A contents (assessments info, new parameters); this commit corrects these along with a couple of others.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@wendellpiez wendellpiez changed the title Corrections to content Correcting conversion glitches in SP800-53A content Sep 19, 2022
@wendellpiez wendellpiez marked this pull request as draft September 19, 2022 17:19
@wendellpiez wendellpiez marked this pull request as ready for review September 20, 2022 18:13
@david-waltermire david-waltermire linked an issue Sep 22, 2022 that may be closed by this pull request
@david-waltermire david-waltermire linked an issue Sep 23, 2022 that may be closed by this pull request
@david-waltermire
Copy link
Contributor

The whitespace reformatter provided here is a partial solution to usnistgov/OSCAL#1183.

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire merged commit e4022c7 into usnistgov:develop Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

800-53 rev5 control title deficiencies Aren't these errors? (SP800-53A encoding issues)
2 participants