10391: remove dynamo messages from tests

ustaxcourt · Oct 23, 2024 · 3000874 · 3000874
1 parent 7e617fb
commit 3000874
Show file tree

Hide file tree

Showing 14 changed files with 76 additions and 434 deletions.
diff --git a/docs/dynamodb-access-patterns.csv b/docs/dynamodb-access-patterns.csv
@@ -6,7 +6,6 @@ associate an irs practitioner onto a case,case|${CASE_ID},irsPractitioner|${USER
 associate a private practitioner onto a case,case|${CASE_ID},privatePractitioner|${USER_ID},leadCase|${LEAD_CASE_ID}
 associate docket entry on a case,case|${CASE_ID},docket-entry|${DOCKET_ENTRY_ID},
 add correspondence to a case,case|${CASE_ID},correspondence|${CORRESPONDENCE_ID},
-associate message onto a case,case|${CASE_ID},message|${MESSAGE_ID},message|${MESSAGE_ID}
 add a hearing to a case,case|${CASE_ID},hearing|${TRIAL_SESSION_ID},
 a work item on a case,case|${CASE_ID},work-item|${WORK_ITEM_ID},work-item|${WORK_ITEM_ID},assigneeId|${ASSIGNEE_ID}
 docket number generator counter,docketNumberCounter-${YEAR},docketNumberCounter-${YEAR},

diff --git a/scripts/run-once-scripts/create-messages.sh b/scripts/run-once-scripts/create-messages.sh
diff --git a/scripts/run-once-scripts/create-messages.ts b/scripts/run-once-scripts/create-messages.ts
diff --git a/web-api/src/business/useCases/messages/completeMessageInteractor.test.ts b/web-api/src/business/useCases/messages/completeMessageInteractor.test.ts
@@ -29,8 +29,6 @@ describe('completeMessageInteractor', () => {
       message: 'hello world',
       messageId: '829e790e-3c22-4308-9267-a251c0d4ce77',
       parentMessageId: '829e790e-3c22-4308-9267-a251c0d4ce77',
-      pk: 'case|3079c990-cc6c-4b99-8fca-8e31f2d9e7a8',
-      sk: 'message|5a79c990-cc6c-4b99-8fca-8e31f2d9e78a',
       subject: 'hey!',
       to: 'bob',
       toSection: PETITIONS_SECTION,
@@ -48,8 +46,6 @@ describe('completeMessageInteractor', () => {
       message: 'hello world2',
       messageId: 'ee84c7d5-31db-40dc-b1cc-7913be7138e8',
       parentMessageId: '829e790e-3c22-4308-9267-a251c0d4ce77',
-      pk: 'case|3079c990-cc6c-4b99-8fca-8e31f2d9e7a8',
-      sk: 'message|ee84c7d5-31db-40dc-b1cc-7913be7138e8',
       subject: 'hey!',
       to: 'bob',
       toSection: PETITIONS_SECTION,

diff --git a/web-api/src/business/useCases/messages/getCompletedMessagesForSectionInteractor.test.ts b/web-api/src/business/useCases/messages/getCompletedMessagesForSectionInteractor.test.ts
@@ -12,7 +12,6 @@ import {
   mockPetitionerUser,
   mockPetitionsClerkUser,
 } from '@shared/test/mockAuthUsers';
-import { omit } from 'lodash';
 
 describe('getCompletedMessagesForSectionInteractor', () => {
   it('throws unauthorized for a user without MESSAGES permission', async () => {
@@ -47,8 +46,6 @@ describe('getCompletedMessagesForSectionInteractor', () => {
       message: "How's it going?",
       messageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       parentMessageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      pk: 'case|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      sk: 'message|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       subject: 'Hey!',
       to: 'Test Petitionsclerk',
       toSection: PETITIONS_SECTION,
@@ -68,6 +65,6 @@ describe('getCompletedMessagesForSectionInteractor', () => {
     );
 
     expect(getCompletedSectionInboxMessages).toHaveBeenCalled();
-    expect(returnedMessages).toMatchObject([omit(messageData, 'pk', 'sk')]);
+    expect(returnedMessages).toMatchObject([messageData]);
   });
 });
diff --git a/web-api/src/business/useCases/messages/getCompletedMessagesForUserInteractor.test.ts b/web-api/src/business/useCases/messages/getCompletedMessagesForUserInteractor.test.ts
@@ -11,7 +11,6 @@ import {
   mockPetitionerUser,
   mockPetitionsClerkUser,
 } from '@shared/test/mockAuthUsers';
-import { omit } from 'lodash';
 
 describe('getCompletedMessagesForUserInteractor', () => {
   it('throws unauthorized for a user without MESSAGES permission', async () => {
@@ -47,8 +46,6 @@ describe('getCompletedMessagesForUserInteractor', () => {
       message: "How's it going?",
       messageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       parentMessageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      pk: 'case|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      sk: 'message|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       subject: 'Hey!',
       to: 'Test Petitionsclerk',
       toSection: PETITIONS_SECTION,
@@ -66,6 +63,6 @@ describe('getCompletedMessagesForUserInteractor', () => {
     );
 
     expect(getCompletedUserInboxMessages).toHaveBeenCalled();
-    expect(returnedMessages).toMatchObject([omit(messageData, 'pk', 'sk')]);
+    expect(returnedMessages).toMatchObject([messageData]);
   });
 });
diff --git a/web-api/src/business/useCases/messages/getInboxMessagesForSectionInteractor.test.ts b/web-api/src/business/useCases/messages/getInboxMessagesForSectionInteractor.test.ts
@@ -12,7 +12,6 @@ import {
   mockPetitionerUser,
   mockPetitionsClerkUser,
 } from '@shared/test/mockAuthUsers';
-import { omit } from 'lodash';
 
 describe('getInboxMessagesForSectionInteractor', () => {
   it('throws unauthorized for a user without MESSAGES permission', async () => {
@@ -43,8 +42,6 @@ describe('getInboxMessagesForSectionInteractor', () => {
       message: "How's it going?",
       messageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       parentMessageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      pk: 'case|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      sk: 'message|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       subject: 'Hey!',
       to: 'Test Petitionsclerk',
       toSection: PETITIONS_SECTION,
@@ -64,6 +61,6 @@ describe('getInboxMessagesForSectionInteractor', () => {
     );
 
     expect(getSectionInboxMessages).toHaveBeenCalled();
-    expect(returnedMessages).toMatchObject([omit(messageData, 'pk', 'sk')]);
+    expect(returnedMessages).toMatchObject([messageData]);
   });
 });
diff --git a/web-api/src/business/useCases/messages/getInboxMessagesForUserInteractor.test.ts b/web-api/src/business/useCases/messages/getInboxMessagesForUserInteractor.test.ts
@@ -11,7 +11,6 @@ import {
   mockPetitionerUser,
   mockPetitionsClerkUser,
 } from '@shared/test/mockAuthUsers';
-import { omit } from 'lodash';
 
 describe('getInboxMessagesForUserInteractor', () => {
   it('throws unauthorized for a user without MESSAGES permission', async () => {
@@ -42,8 +41,6 @@ describe('getInboxMessagesForUserInteractor', () => {
       message: "How's it going?",
       messageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       parentMessageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      pk: 'case|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      sk: 'message|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       subject: 'Hey!',
       to: 'Test Petitionsclerk',
       toSection: PETITIONS_SECTION,
@@ -63,6 +60,6 @@ describe('getInboxMessagesForUserInteractor', () => {
     );
 
     expect(getUserInboxMessages).toHaveBeenCalled();
-    expect(returnedMessages).toMatchObject([omit(messageData, 'pk', 'sk')]);
+    expect(returnedMessages).toMatchObject([messageData]);
   });
 });
diff --git a/web-api/src/business/useCases/messages/getOutboxMessagesForSectionInteractor.test.ts b/web-api/src/business/useCases/messages/getOutboxMessagesForSectionInteractor.test.ts
@@ -12,7 +12,6 @@ import {
   mockPetitionerUser,
   mockPetitionsClerkUser,
 } from '@shared/test/mockAuthUsers';
-import { omit } from 'lodash';
 
 describe('getOutboxMessagesForSectionInteractor', () => {
   it('throws unauthorized for a user without MESSAGES permission', async () => {
@@ -43,8 +42,6 @@ describe('getOutboxMessagesForSectionInteractor', () => {
       message: "How's it going?",
       messageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       parentMessageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      pk: 'case|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      sk: 'message|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       subject: 'Hey!',
       to: 'Test Petitionsclerk',
       toSection: PETITIONS_SECTION,
@@ -64,6 +61,6 @@ describe('getOutboxMessagesForSectionInteractor', () => {
     );
 
     expect(getSectionOutboxMessages).toHaveBeenCalled();
-    expect(returnedMessages).toMatchObject([omit(messageData, 'pk', 'sk')]);
+    expect(returnedMessages).toMatchObject([messageData]);
   });
 });
diff --git a/web-api/src/business/useCases/messages/getOutboxMessagesForUserInteractor.test.ts b/web-api/src/business/useCases/messages/getOutboxMessagesForUserInteractor.test.ts
@@ -11,7 +11,6 @@ import {
   mockPetitionerUser,
   mockPetitionsClerkUser,
 } from '@shared/test/mockAuthUsers';
-import { omit } from 'lodash';
 
 describe('getOutboxMessagesForUserInteractor', () => {
   it('throws unauthorized for a user without MESSAGES permission', async () => {
@@ -42,8 +41,6 @@ describe('getOutboxMessagesForUserInteractor', () => {
       message: "How's it going?",
       messageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       parentMessageId: '9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      pk: 'case|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
-      sk: 'message|9ca37b65-9aac-4621-b5d7-e4a7c8a26a21',
       subject: 'Hey!',
       to: 'Test Petitionsclerk',
       toSection: PETITIONS_SECTION,
@@ -63,6 +60,6 @@ describe('getOutboxMessagesForUserInteractor', () => {
     );
 
     expect(getUserOutboxMessages).toHaveBeenCalled();
-    expect(returnedMessages).toMatchObject([omit(messageData, 'pk', 'sk')]);
+    expect(returnedMessages).toMatchObject([messageData]);
   });
 });
diff --git a/web-api/src/business/useCases/processStreamRecords/processMessageEntries.test.ts b/web-api/src/business/useCases/processStreamRecords/processMessageEntries.test.ts
@@ -26,12 +26,6 @@ describe('processMessageEntries', () => {
           messageId: {
             S: 'a73c3ff5-2daf-4bbd-91d1-e8e7543346e0',
           },
-          pk: {
-            S: 'case|123-45',
-          },
-          sk: {
-            S: 'message|229f79aa-22d1-426e-98e2-5d9f2af472b6',
-          },
         },
       },
     };