Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Country in v2 JSON for Petitioners #5377

Open
20 tasks
mmarcotte opened this issue Sep 18, 2024 · 0 comments
Open
20 tasks

Include Country in v2 JSON for Petitioners #5377

mmarcotte opened this issue Sep 18, 2024 · 0 comments

Comments

@mmarcotte
Copy link
Collaborator

As a consumer of the V2 API, so that can have all of the relevant information, I need Country included in the JSON for the Petitioner.

Pre-Conditions

Acceptance Criteria

  • Contact.country is included in the documentation
  • country is included in the JSON for a petitioner if one is present

Notes

Tasks

  • update documentation
  • update marsthaller
  • test it out

Test Cases

Definition of Done (Updated 01-16-24)

Product Owner

Engineering

  • Automated test scripts have been written, including visual tests for newly added PDFs.
  • Field level and page level validation errors (front-end and server-side) integrated and functioning.
  • New screens have been added to cypress accessibility axe
  • All new functionality verified to work with keyboard and macOS voiceover https://www.apple.com/voiceover/info/guide/_1124.html.
  • Swagger docs have been updated if API endpoints have been added or updated.
  • UI should be touch optimized and responsive for external users.
  • Interactors should validate entities before calling persistence methods.
  • Features have been optimized where possible to reduce response times. For example, reducing api response times, parallelizing client network calls, optimizing database reads, etc.
  • Types have been added to all added and updated functions.
  • Code refactored for clarity and to remove any known technical debt.
  • Acceptance criteria for the story has been met.
  • If there are special instructions in order to deploy into the next environment, add them as a comment in the story.
  • Code that resides in the shared folder that only runs on the API or browser has been moved to either /web-client or /web-api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant