Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10261 Story: Practitioner Case List (Slight update to spacing and letting icons be accessible via VoiceOver) #5470

Merged
merged 4 commits into from
Oct 17, 2024
Merged

10261 Story: Practitioner Case List (Slight update to spacing and letting icons be accessible via VoiceOver) #5470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
199b9b7
10261-story: keep spacing in PractitionerDetails even if the edit but…
Mwindo Oct 17, 2024
4f545d9
10261: remove aria-hidden from meaningful icons
Mwindo Oct 17, 2024
15039c3
10261-story: fix minor typo
Mwindo Oct 17, 2024
61afabd
10261-story: update margin slightly for better alignment across tabs
Mwindo Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-client/src/views/Practitioners/PractitionerCaseList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ export function PractitionerCaseList({
>
<thead>
<tr>
<th aria-hidden="true" className="icon-column" />
<th className="icon-column" />
<th className="no-wrap">Docket No.</th>
<th>Case Title</th>
{showStatus && <th>Case Status</th>}
</tr>
</thead>
{cases.map(item => (
<tr key={item.docketNumberWithSuffix}>
<td aria-hidden="true">
<td>
<PractitionerCaseIcons formattedCase={item} />
</td>
<td>
Expand Down
4 changes: 3 additions & 1 deletion web-client/src/views/Practitioners/PractitionerDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export const PractitionerDetails = connect(
</Button>
)}
</div>
<div className="grid-row grid-gap">
<div
className={`grid-row grid-gap ${practitionerDetailHelper.showEditLink ? '' : 'margin-top-5'}`} // Maintain the spacing even if there is no edit button
>
<div className="tablet:grid-col-4 margin-bottom-4">
<div className="card height-full margin-bottom-0">
<div className="content-wrapper">
Expand Down
Loading