Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10261 Story: Update to sealed icon hover text #5475

Merged
merged 4 commits into from
Oct 21, 2024
Merged

10261 Story: Update to sealed icon hover text #5475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e3aa6b
10261-story: fix sealed icon hover text
Mwindo Oct 21, 2024
7e333ba
Merge remote-tracking branch 'ustc/test' into 10261-story-sealed-icon…
Mwindo Oct 21, 2024
73d4d2b
10261-story: trigger build to see if weird test failure continues
Mwindo Oct 21, 2024
6b1f412
10261-story: fix Icon title, thanks to feedback from Tom
Mwindo Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shared/src/business/utilities/getSealedDocketEntryTooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// This applies only to docket entries, not to full cases
export const getSealedDocketEntryTooltip = (applicationContext, entry) => {
const { DOCKET_ENTRY_SEALED_TO_TYPES } = applicationContext.getConstants();

Expand Down
12 changes: 1 addition & 11 deletions web-client/src/presenter/computeds/practitionerInformationHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,17 @@ import { state } from '@web-client/presenter/app.cerebral';

import { Get } from 'cerebral';
import { PractitionerCaseDetail } from '@web-client/presenter/state';
import { getSealedDocketEntryTooltip } from '@shared/business/utilities/getSealedDocketEntryTooltip';

const PAGE_SIZE = 100;

const getPagesToDisplay = ({
applicationContext,
cases,
pageNumber,
}: {
pageNumber: number;
cases: PractitionerCaseDetail[];
applicationContext: ClientApplicationContext;
}) => {
return cases
.slice(pageNumber * PAGE_SIZE, (pageNumber + 1) * PAGE_SIZE)
.map(c => {
c.sealedToTooltip = getSealedDocketEntryTooltip(applicationContext, c);
return c;
});
return cases.slice(pageNumber * PAGE_SIZE, (pageNumber + 1) * PAGE_SIZE);
};

export const practitionerInformationHelper = (
Expand Down Expand Up @@ -64,13 +56,11 @@ export const practitionerInformationHelper = (
const showClosedCasesPagination = totalClosedCasesPages > 1;

const openCasesToDisplay = getPagesToDisplay({
applicationContext,
cases: practitionerDetail.openCaseInfo?.allCases || [],
pageNumber: practitionerDetail.openCaseInfo?.currentPage || 0,
});

const closedCasesToDisplay = getPagesToDisplay({
applicationContext,
cases: practitionerDetail.closedCaseInfo?.allCases || [],
pageNumber: practitionerDetail.closedCaseInfo?.currentPage || 0,
});
Expand Down
3 changes: 2 additions & 1 deletion web-client/src/styles/custom.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,7 +1794,8 @@ button.change-scanner-button {
margin-right: 4px;
}

.sealed-docket-entry {
.sealed-docket-entry,
.sealed-case-entry {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an iconSealed class, but it doesn't do what I need (it is too opinionated). Rather than using that one or using sealed-docket-entry (which is poorly named in my context), I made a new, more appropriately named class.

color: color($theme-color-secondary-dark);
}

Expand Down
6 changes: 3 additions & 3 deletions web-client/src/views/Practitioners/PractitionerCaseIcons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ export function PractitionerCaseIcons({
<div className="multi-filing-type-icon">
{formattedCase.isSealed && (
<Icon
aria-label={formattedCase.sealedToTooltip}
className="sealed-docket-entry"
aria-label="sealed"
className="sealed-case-entry"
icon="lock"
title={formattedCase.sealedToTooltip}
title="sealed"
/>
)}
{formattedCase.inConsolidatedGroup && (
Expand Down
Loading